#include <stdio.h>
int main()
{
    int i;
    char surname[30];
    char name[30], matricno[10];
    int A, B, C;
    FILE *file, *file1;

    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }


        file1 = fopen("newbroadsheet.txt", "w";
        fprintf(file1, "University of Nairaland\n";
        fprintf(file1, "Department of Programming\n";
        fprintf(file1, "================================\n";

        while (!feof(file)) {
        fscanf(file, "%s\t%s\t%d\t%d\n", &name, &matricno, &A, &B);
        fprintf(file1, "%s\t%s\t%d\t%d\n", name, matricno, A, B);
         }
}

stack1:
It might have to do with the file contents, somehow, what fscanf is reading in isnt matching the requirements for in A and B,
that is a mismatched type is been read, so garbage would be stored in A & B then printed out, either non-integers are being read or some kind of overflow is occuring, may be paste the content of the input file

#include <stdio.h>
int main()
{
    int i, C;
    char surname[30];
    char name[30], matricno[30];
    char MIT801[6], MIT802[6];
    FILE *file, *file1;

    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }


        file1 = fopen("newbroadsheet.txt", "w";
        fprintf(file1, "University of Nairaland\n";
        fprintf(file1, "Department of Programming\n";
        fprintf(file1, "================================\n";

        while (!feof(file)) {
        fscanf(file, "%s %s %s %s", name, matricno, MIT801, MIT802);
        fprintf(file1, "%s\t%s\t%s\t%s\n", name, matricno, MIT801, MIT802);
         }

babajeje123:

Thank you @ Stack. I have corrected the data type bug. However, I still don't get the output file well formatted. Here is the screenshot with the new codes

#include <stdio.h>
int main()
{
    int i, C;
    char surname[30];
    char name[30], matricno[30];
    char MIT801[6], MIT802[6];
    FILE *file, *file1;

    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }


        file1 = fopen("newbroadsheet.txt", "w";
        fprintf(file1, "University of Nairaland\n";
        fprintf(file1, "Department of Programming\n";
        fprintf(file1, "================================\n";

        while (!feof(file)) {
        fscanf(file, "%s %s %s %s", name, matricno, MIT801, MIT802);
        fprintf(file1, "%s\t%s\t%s\t%s\n", name, matricno, MIT801, MIT802);
         }

"matricno" and "MIT801" are missing in the output file.

#include <stdio.h>
int main()
{
    int i, C;
    char surname[30];
    char name[30], matricno[30];
    char MIT801[6], MIT802[6];
    FILE *file, *file1;

    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }


        file1 = fopen("newbroadsheet.txt", "w";
        fprintf(file1, "University of Nairaland\n";
        fprintf(file1, "Department of Programming\n";
        fprintf(file1, "================================\n";

        while (!feof(file)) {
        fscanf(file, "%s %s %s %s", name, matricno, MIT801, MIT802);
        fprintf(file1, "%s\t%s\t%s\t%s\n", name, matricno, MIT801, MIT802);
         }

ChinenyeN:
Babajeje123, looking at your code and the output screen shot from earlier, the first thing that comes to mind is how the data is stored in the Broadsheett.txt file. What sort of whitespace separates the fields? Is it a regular space or a tab or something else?

Try replacing the blank space in your fscanf format string with \t and tell us what happens with the output.

babajeje123:
I did what you suggested but nothing was printed on the new file that was created.

ChinenyeN:
Babajeje123, my suggestion to you, would be to not use fscanf. In place of fscanf, try fgets. If so, fgets can be used to grab each record, and then strtok for instance can be used to tokenize each string in the record.

It's more code, and it would require that other parts of your program be rewritten, but at least it gives you enough fine control to help ensure that all the desired fields are accounted for. You can still use fprint to generate the new file. There's no reason why that should change, because fscanf seems to be the real problem here, as far as I can tell.

ChinenyeN:
Babajeje123, my suggestion to you, would be to not use fscanf. In place of fscanf, try fgets. I imagine that the records in the original data .txt file are all separated by a newline character. If so, fgets can be used to grab each record, and then strtok for instance can be used to tokenize each string in the record.

It's more code, and it would require that other parts of your program be rewritten, but at least it gives you enough fine control to help ensure that all the desired fields are accounted for. You can still use fprint to generate the new file. There's no reason why that should change, because fscanf seems to be the real problem here, as far as I can tell.

#include <stdio.h>
int main()
{
    int i, c;
    char surname[30];
    char name[30], matricno[30];
    int mit801, mit802, total;
    char grade;
    FILE *file, *file1;

    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }


        file1 = fopen("newbroadsheet.txt", "w";
        fprintf(file1, "University of Lagos\n";
        fprintf(file1, "======================\n";
        fprintf(file1, "Faculty of Sciences\n";
        fprintf(file1, "======================\n";
        fprintf(file1, "Department of Computer Sciences\n";
        fprintf(file1, "================================\n";

        while (!feof(file)) {
        fscanf(file, "%s%s%d%d", name, matricno, &mit801, &mit802);     
        total = mit801 + mit802;
        fprintf(file1, "%s\t%s\t%d\t%d\t%d\n", name, matricno, mit801, grade, mit802, total);
         }
}

ChinenyeN:
Well, babajeje123, the first line of your input file is technically headers. So, you'd have to read them in with the %s specifier, because the %d specifier results in an incorrect data type which then give you garbage values.

Here's my recommendation. Consider reading the first line separately in some way. In other words, write your code to consider the header names, which are strings and not integers. Then, once the headers have been taken care of, you can switch to using the %d specifier and evaluate the rest of the input file.

#include <stdio.h>
int main()
{
    int i, c, tcunit = 15;  //tunit means total course unit
    char surname[30];
    char name[30], matricno[30];
    int mit801, mit802, mit803, mit805, mit821, total;
    float average;
    char *grade, *grade2, *grade3, *grade4, *grade5;
    FILE *file, *file1;
    
    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }

	/*Creating and writing into a new file */	
        file1 = fopen("\tnewbroadsheet.txt", "w";
        fprintf(file1, "\tUniversity of Lagos\n";
        fprintf(file1, "\t======================\n";
        fprintf(file1, "\tFaculty of Sciences\n";
        fprintf(file1, "\t======================\n";
        fprintf(file1, "\tDepartment of Computer Sciences\n";
        fprintf(file1, "\t================================\n";
        fprintf(file1, "\tBROADSHEET FOR MIT1 STUDENTS, 2016/2017 SESSION";
        fprintf(file1, "\t%s\t%s\t%s\t%s\t%s\t%s\t%s\n", "NAME", "MATRICNO", "MIT801", "MIT802", "MIT803", "MIT805", "MIT821";

        while (!feof(file)) {
        fscanf(file, "%s%s%d%d%d%d%d\n", name, matricno, &mit801, &mit802, &mit803, &mit805, &mit821);      
        
        /*Generating grades for scores/marks */
        /* Determining the grade for MIT801 */
        if (mit801 >= 70)
        grade = 'A';
        
        else if (mit801 >= 60)
        grade = 'B';
       
        else if (mit801 >= 50)
		grade = 'C';
		
		else if (mit801 >= 45)
		grade = 'D';
		
		else if (mit801 >= 40)	
		grade = 'E';
	
		else
		grade = 'F';
				
		/* Determining the grade for MIT802 */
		
		if (mit802 >= 70)
        grade2 = 'A';
        else if (mit802 >= 60)
        grade2 = 'B';
        else if (mit802 >= 50)
		grade2 = 'C';
		else if (mit802 >= 45)
		grade2 = 'D';
		else if (mit802 >= 40)	
		grade2 = 'E';
		else
		grade2 = 'F'; 
		/* Determining the grade for MIT803 */
		if (mit803 >= 70)
        grade3 = 'A';
        else if (mit803 >= 60)
        grade3 = 'B';
        else if (mit803 >= 50)
		grade3 = 'C';
		else if (mit803 >= 45)
		grade3 = 'D';
		else if (mit803 >= 40)	
		grade3 = 'E';
		else
		grade3 = 'F';
		/* Determining the grade for MIT805 */
		if (mit805 >= 70)
        grade4 = 'A';
        else if (mit805 >= 60)
        grade4 = 'B';
        else if (mit805 >= 50)
		grade4 = 'C';
		else if (mit805 >= 45)
		grade4 = 'D';
		else if (mit805 >= 40)	
		grade4 = 'E';
		else
		grade4 = 'F';
		/* Determining the grade for MIT821 */			
		if (mit821 >= 70)
        grade5 = 'A';
        else if (mit821 >= 60)
        grade5 = 'B';
        else if (mit821 >= 50)
		grade5 = 'C';
		else if (mit821 >= 45)
		grade5 = 'D';
		else if (mit821 >= 40)	
		grade5 = 'E';
		else
		grade5 = 'F'; 
		              
        
        fprintf(file1, "\t%s\t%s\t%d%s\t%d%s\t%d%s\t%d%s\t%d%s\n", name, matricno, mit801, &grade, mit802, &grade2, mit803, &grade3, mit805, &grade4, mit821, &grade5);         
		} 
}

ChinenyeN:
I don't consider myself that great of a programmer or that smart of a person that I would be someone else's mentor. But, I don't mind being available when I can to help you out when you get stuck. It's usually just a matter of critical thinking.

ChinenyeN:
As for making your code more concise....

Considering that you are repeating the same if/else if conditions, why not write a loop statement that will contain the if/else if blocks and evaluate all the mit* values within the loop. This will effectively get rid of all the repeated if/else if blocks.

uzoexcel:
Take lecture vids on newBoston.org

babajeje123:

uzoexcel:
Take lecture vids on newBoston.org

babajeje123:
Thanks bro. I've been able to generate the broadsheet with marks and grades. However, I think the lines of codes that generate the grades should be concise. Also, I need to calculate the GPA of each student. Do you have an idea of how to go about this? My new code is given below

#include <stdio.h>
int main()
{
    int i, c, tcunit = 15;  //tunit means total course unit
    char surname[30];
    char name[30], matricno[30];
    int mit801, mit802, mit803, mit805, mit821, total;
    float average;
    char *grade, *grade2, *grade3, *grade4, *grade5;
    FILE *file, *file1;
    
    /* Open an existing file */
    file = fopen("Broadsheett.txt","r";
      if(file == NULL){
      printf("Error: Unable to open a file";
      }

	/*Creating and writing into a new file */	
        file1 = fopen("\tnewbroadsheet.txt", "w";
        fprintf(file1, "\tUniversity of Lagos\n";
        fprintf(file1, "\t======================\n";
        fprintf(file1, "\tFaculty of Sciences\n";
        fprintf(file1, "\t======================\n";
        fprintf(file1, "\tDepartment of Computer Sciences\n";
        fprintf(file1, "\t================================\n";
        fprintf(file1, "\tBROADSHEET FOR MIT1 STUDENTS, 2016/2017 SESSION";
        fprintf(file1, "\t%s\t%s\t%s\t%s\t%s\t%s\t%s\n", "NAME", "MATRICNO", "MIT801", "MIT802", "MIT803", "MIT805", "MIT821";

        while (!feof(file)) {
        fscanf(file, "%s%s%d%d%d%d%d\n", name, matricno, &mit801, &mit802, &mit803, &mit805, &mit821);      
        
        /*Generating grades for scores/marks */
        /* Determining the grade for MIT801 */
        if (mit801 >= 70)
        grade = 'A';
        
        else if (mit801 >= 60)
        grade = 'B';
       
        else if (mit801 >= 50)
		grade = 'C';
		
		else if (mit801 >= 45)
		grade = 'D';
		
		else if (mit801 >= 40)	
		grade = 'E';
	
		else
		grade = 'F';
				
		/* Determining the grade for MIT802 */
		
		if (mit802 >= 70)
        grade2 = 'A';
        else if (mit802 >= 60)
        grade2 = 'B';
        else if (mit802 >= 50)
		grade2 = 'C';
		else if (mit802 >= 45)
		grade2 = 'D';
		else if (mit802 >= 40)	
		grade2 = 'E';
		else
		grade2 = 'F'; 
		/* Determining the grade for MIT803 */
		if (mit803 >= 70)
        grade3 = 'A';
        else if (mit803 >= 60)
        grade3 = 'B';
        else if (mit803 >= 50)
		grade3 = 'C';
		else if (mit803 >= 45)
		grade3 = 'D';
		else if (mit803 >= 40)	
		grade3 = 'E';
		else
		grade3 = 'F';
		/* Determining the grade for MIT805 */
		if (mit805 >= 70)
        grade4 = 'A';
        else if (mit805 >= 60)
        grade4 = 'B';
        else if (mit805 >= 50)
		grade4 = 'C';
		else if (mit805 >= 45)
		grade4 = 'D';
		else if (mit805 >= 40)	
		grade4 = 'E';
		else
		grade4 = 'F';
		/* Determining the grade for MIT821 */			
		if (mit821 >= 70)
        grade5 = 'A';
        else if (mit821 >= 60)
        grade5 = 'B';
        else if (mit821 >= 50)
		grade5 = 'C';
		else if (mit821 >= 45)
		grade5 = 'D';
		else if (mit821 >= 40)	
		grade5 = 'E';
		else
		grade5 = 'F'; 
		              
        
        fprintf(file1, "\t%s\t%s\t%d%s\t%d%s\t%d%s\t%d%s\t%d%s\n", name, matricno, mit801, &grade, mit802, &grade2, mit803, &grade3, mit805, &grade4, mit821, &grade5);         
		} 
}

When you run this, you'll have "assignment makes pointer from integer without a cast" as a warning. What does it mean?

celis:
thanks for this! Please i dont even know where to start from. I've been running from one error to the other all day. i can see you are reading from .txt . I taught the question says to read from excel file. Can you help a brother with the final code please?

ChinenyeN:
Babajeje123, congratulations on finishing your assignment. It's good to know that the program compiles and executes as expected.

About C, if you never intend on doing anything relatively low-level, then you likely will never have to worry about using C after your exam. There are other general purpose programming languages that will do the same thing as C, but with less lines of code. C shines more so as a bootstrapping language (the language that interpreters and compilers are sometimes initially written in), and it shines especially more so as a systems programming language (the language that kernels and OS's and OS utilities are mostly written in).

If you don't have any need for any of these software engineering routes in the future, then you likely will have little need for C. It doesn't mean you can't use C for other things besides system programming. C is still a general purpose programming language. It can be used for practically anything.

Aside from that, C still runs the world, and it seems like it will always be around for the foreseeable future. C is just so intertwined with current computer architecture that the only way for C to become irrelevant is if we start designing and building computers differently. Until then, there will always be a need for someone to pay attention to C.

#include <stdio.h>
#include <conio.h>

int main(){
    int i = 3;
    printf("%d%d", i, i++);
}

#include <stdio.h>
#include <conio.h>

int main(){
    int i = 1;
    j = i--- -2;
    printf("%d", j);
}

 j = i-- -(-2);