Good day, auto gurus in the house, I owned and drive a pontiac vibe 2004. Two years back, I noticed a small noise from the crankshaft, especially on a turn. My mechanic advises that I should continue until the noise is noticeable then we can overhaul the shaft. After two years the noise remained the same. What is your advice, the car gurus in the house?

Replace it, if you have money, but you can still use it though if you don't have money to change it.

My front right shaft makes the same noise when I turn. Mechanic says I can still use for 2 years, but I'll replace soon.

I like to be on a safer side!

Your post is confusing... Do you mean crankshaft or front hub shaft.
Crankshaft is an engine component. It's a rotating shaft that converts reciprocating motion of a piston into a rotational motion. Your vehicle's issue has nothing to do with your crankshaft. Your problem is not far from any of these: brake pad, caliper, steering shaft, hub shaft on a rare case